gui: /rest/system/browse with no arguments returns drives on Windows … #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| kernel32, err := syscall.LoadDLL("kernel32.dll") | ||
| if err != nil { | ||
| return drives | ||
| } |
There was a problem hiding this comment.
doesn't really matter does it?
There was a problem hiding this comment.
It matters only in that when looking at this I need to keep track of if we've actually done anything with drives to see what we return in the error cases. That's trivial in the first case but when looking at line 34 I actually have to parse lines 18-33 as well to understand what it means.
As an aside, shouldn't we just return ([]string, error) and let the API return a 500 when this fails on Windows? The empty success response isn't meaningful by itself, is it?
|
Bump. |
|
@st-review merge it! |
|
👌 Merged as 1612bac. Thanks, @AudriusButkevicius! |
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title