gui: Be more explicit about how assets should be cached (fixes #3182) #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing#3182) With the previous setup, browsers were free to use a local cache for any length of time they pleased: we didn't set an 'Expires' header (or max-age directive), and Cache-Control just said "you're free to cache this". Therefore be more explicit: we don't mind if browsers cache things, but they MUST revalidate everything on every request.
|
LGTM, leave for @calmh to merge. |
|
@st-review merge please cmd/syncthing: Be more explicit about how assets should be cached (fixes #3182) With the previous setup, browsers were free to use a local cache for any Therefore be more explicit: we don't mind if browsers cache things, but |
st-review
pushed a commit
that referenced
this pull request
May 30, 2016
#3182) With the previous setup, browsers were free to use a local cache for any length of time they pleased: we didn't set an 'Expires' header (or max-age directive), and Cache-Control just said "you're free to cache this". Therefore be more explicit: we don't mind if browsers cache things, but they MUST revalidate everything on every request. GitHub-Pull-Request: #3221
This was referenced May 30, 2016
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
With the previous setup, browsers were free to use a local cache for any
length of time they pleased: we didn't set an 'Expires' header (or
max-age directive), and Cache-Control just said "you're free to cache
this".
Therefore be more explicit: we don't mind if browsers cache things, but
they MUST revalidate everything on every request.
Testing
Set
STTRACE=http, reloaded lots in some browsers, saw that browsers always revalidated.