Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: Improve changelog layout #3228

Closed
wants to merge 1 commit into from
Closed

script: Improve changelog layout #3228

wants to merge 1 commit into from

Conversation

calmh
Copy link
Member

@calmh calmh commented May 31, 2016

Purpose

Pull issue information from Github to show both the resolved issue subject and the commit subject. Also show reviewer, when different from author.

Example:

* #3201: api: /rest/system/browse behaves strangely on Windows

  lib/osutil: Fix globbing at root (by @AudriusButkevicius, reviewed by
  @calmh)

* #3174: Ignore patterns with non-ASCII characters causes out of memory
  crash

  vendor: Update github.com/gobwas/glob (by @calmh)

Pull issue information from Github to show both the resolved issue
subject and the commit subject. Also show reviewer, when different from
author.

    * #3201: api: /rest/system/browse behaves strangely on Windows

      lib/osutil: Fix globbing at root (by @AudriusButkevicius, reviewed by
      @calmh)

    * #3174: Ignore patterns with non-ASCII characters causes out of memory
      crash

      vendor: Update github.com/gobwas/glob (by @calmh)
@calmh
Copy link
Member Author

calmh commented May 31, 2016

(Everyone please feel free to touch up issue subjects so they make some rough sort of sense in the future.)

@AudriusButkevicius
Copy link
Member

@st-review merge

@st-review
Copy link

@AudriusButkevicius: Build status is pending. I'll wait until it goes green and then merge!

@st-review
Copy link

👌 Merged as a775dd2. Thanks, @calmh!

@st-review st-review closed this May 31, 2016
st-review pushed a commit that referenced this pull request May 31, 2016
Pull issue information from Github to show both the resolved issue
subject and the commit subject. Also show reviewer, when different from
author.

    * #3201: api: /rest/system/browse behaves strangely on Windows

      lib/osutil: Fix globbing at root (by @AudriusButkevicius, reviewed by
      @calmh)

    * #3174: Ignore patterns with non-ASCII characters causes out of memory
      crash

      vendor: Update github.com/gobwas/glob (by @calmh)

GitHub-Pull-Request: #3228
@AudriusButkevicius
Copy link
Member

AudriusButkevicius commented May 31, 2016

You can also adjust the merge bot to refuse merging if issue title does not match something.

@calmh calmh deleted the changelog branch June 1, 2016 07:11
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jun 16, 2017
@syncthing syncthing locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants