cmd/syncthing: Remove folder limit on /rest/system/browse #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously limited to 10 results, now unlimited.
|
@st-review lgtm @AudriusButkevicius wrote this from the start and may remember the reasoning, I would expect it's mostly to protect the browser from too large directories but that's not necessarily our problem |
|
@calmh: Noted! Need another LGTM or explicit merge command. |
|
@st-review lgtm |
st-review
pushed a commit
that referenced
this pull request
Jun 8, 2016
Previously limited to 10 results, now unlimited. GitHub-Pull-Request: #3279 LGTM: calmh, AudriusButkevicius
|
It was limited not to have a stupidly large dropdown in the ui, but arguably that should be done in the js code. |
|
Awesome! My testing with Firefox, it shows a scrollbar beside the datalist when there's lots of options. Will need this for jstree if integrated. Limiting should be done in the js code indeed. Thanks. |
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove folder limit on /rest/system/browse
Previously limited to 10 results, is now unlimited.
I'm not sure why it was limited to 10, can someone explain?
Testing
I compiled a build!