gui: Accordion titles as buttons #3284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@st-review lgtm This gives the accordion title the sunken button look when depressed, which can be an advantage or not from my POV. I guess the main point of this is to not change the address as noted?
|
|
@calmh: Noted! Need another LGTM or explicit merge command. |
|
@st-review lgtm |
st-review
pushed a commit
that referenced
this pull request
Jun 8, 2016
GitHub-Pull-Request: #3284 LGTM: calmh, AudriusButkevicius
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces accordion titles with
<button>(was previously<a href>)still works perfect with NVDA, but page no longer navigates to:
https://127.0.0.1:8384/#folder-0https://127.0.0.1:8384/#folder-1https://127.0.0.1:8384/#folder-2https://127.0.0.1:8384/#device-thishttps://127.0.0.1:8384/#device-0https://127.0.0.1:8384/#device-1should look identical