Increase deadline of exchangeHello #3286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently exchangeHello will close connections too soon for links with latency above 1,000ms, increasing it to 20s will allow links with latency up to 10,000ms to not fail exchangeHello handshake. tenorio
|
@st-jenkins add to white list |
|
@st-review merge this please cmd/syncthing: Increase timeout in hello message exchange Required to establish connections on high latency links Skip-check: authors |
|
@calmh: Build status is |
st-review
pushed a commit
that referenced
this pull request
Jun 8, 2016
Required to establish connections on high latency links Skip-check: authors GitHub-Pull-Request: #3286
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix exchangeHello time out over high latency links
-- currently exchangeHello will close connections too soon for links with latency above 1,000ms. This not a common case, but NGOs in general works with remote locations with high latency links.
Increasing the deadline to 20s will allow links with latency up to 10,000ms to not fail exchangeHello handshake.
tenorio