lib/connections: Limit rate at which we print warnings about version mismatch #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@st-review merge |
st-review
pushed a commit
that referenced
this pull request
Jun 9, 2016
…mismatch GitHub-Pull-Request: #3291
| @@ -36,6 +36,8 @@ var ( | |||
| listeners = make(map[string]listenerFactory, 0) | |||
| ) | |||
|
|
|||
| const perDeviceWarningRate = 1.0 / (15 * 60) // Once per 15 minutes | |||
There was a problem hiding this comment.
Suggest we should do this a bit more frequently? A version mis-match is almost never expected in a correct set-up: if it occurs, the user's going to be trying to find out why their devices won't connect. If the first message gets lost in some noise, we don't want them searching around for 15 mins before it pops up again, I would have thought..?
There was a problem hiding this comment.
At least for the GUI, we stash the last five warnings and they're quite infrequent. So it should be available directly in the GUI when opened if it's happened at all recently
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3287. Tested manually.