Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Sort folders by label, fall back to ids if required (fixes #3310) #3326

Closed
wants to merge 1 commit into from
Closed

gui: Sort folders by label, fall back to ids if required (fixes #3310) #3326

wants to merge 1 commit into from

Conversation

xduugu
Copy link
Contributor

@xduugu xduugu commented Jun 18, 2016

Sorts the folders by its labels and uses the folder ID if no label is set.

@calmh
Copy link
Member

calmh commented Jun 18, 2016

Needs var declarations and semicolons, otherwise looks good to me.

@calmh
Copy link
Member

calmh commented Jun 18, 2016

@st-jenkins add to white list

@calmh
Copy link
Member

calmh commented Jun 18, 2016

@st-jenkins retest this please

@xduugu
Copy link
Contributor Author

xduugu commented Jun 18, 2016

Adjusted the patch, thanks.

@calmh
Copy link
Member

calmh commented Jun 18, 2016

@st-review merge it, looks good

@st-review
Copy link

@calmh: Build status is pending. I'll wait until it goes green and then merge!

@st-review
Copy link

👌 Merged as 89a2994. Thanks, @xduugu!

@st-review st-review closed this Jun 18, 2016
st-review pushed a commit that referenced this pull request Jun 18, 2016
@xduugu xduugu deleted the sort-folder-by-label branch June 18, 2016 19:37
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jun 19, 2017
@syncthing syncthing locked and limited conversation to collaborators Jun 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants