lib/connections: TLS handshake must complete in a timely fashion (fixes #3375) #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmh
changed the title
|
@st-review merge |
|
@AudriusButkevicius: Build status is |
|
@AudriusButkevicius: Patiently waited 30m0s for the build status to turn green, but enough is enough. |
|
That's my home internet (where the mac builder lives) being shit :( |
|
@st-review merge it now instead |
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The initial TLS handshake can take infinite time (or the regular TCP timeout at an hour or so) unless explicitly controlled.
Testing
I ran an integration benchmark thing, looks like things can still talk to each other. Haven't verified that the deadline actually kicks in, but I don't see why it wouldn't...