lib/model: Sort outgoing index updates by LocalVersion #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func (s *onDiskIndexSorter) Close() { | ||
| l.Debugf("onDiskIndexSorter %p closes", s) | ||
| s.db.Close() | ||
| os.RemoveAll(s.dir) |
|
The build failed? |
|
Build machine oom? |
|
@st-jenkins retest this please |
|
@AudriusButkevicius please take another look on this one :) |
|
@st-review merge |
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Preparation for delta indexes. To review this part individually and not mix it up unnecessarily with the other changes. Adds some overhead to the initial index exchange, especially if the index is large, but not enough to affect the ManyFiles benchmark negatively in my testing.
Testing
The index sorter is fully covered by unit testing apart from the
panic()ing lines. I've run the benchmarks and those work, so indexes are being sent.Things to Review
I'm panicing in quite a few places in the sorter as I don't want to add error returns that would anyway be annoying to handle. I think the cases where there are panics are those where we would panic anyway - out of disk space, disk I/O failure, unable to marshal a struct, and so on. But I would appreciate an extra eye on it.