lib/db, lib/model: Create temp sorting database in config dir (fixes #3449) #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might be confunsing golang with python, but Is it possible to store the db location in a package-global variable within the model package rather than needlessly passing it around the sendIndexes and sendIndexTo functions? |
|
Global state is evils |
|
That could be one option. Another would be to move the "locations" stuff that now lives in package |
|
@st-review merge |
st-review
pushed a commit
that referenced
this pull request
Jul 27, 2016
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create temp databases beside main database.
A design issue here is that the index sorter is created at a point quite far in the call stack from the closest place or even package that knows anything about disk paths. My solution takes a quite circuitous path via letting the main database know where it lives and have the model check that when it kicks of the index sending routines... I'm all open for suggestions on better ways to do this.
Testing
STTRACE=model, the log "opened sorter" line shows the expected path.