-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/model, lib/config: Support "live" device removal, folder unsharin… #3478
lib/model, lib/config: Support "live" device removal, folder unsharin… #3478
Conversation
f231a44
to
f2b92e6
Compare
@@ -70,7 +70,9 @@ func New(myID protocol.DeviceID) Configuration { | |||
util.SetDefaults(&cfg.Options) | |||
util.SetDefaults(&cfg.GUI) | |||
|
|||
cfg.prepare(myID) | |||
if err := cfg.prepare(myID); err != nil { | |||
panic(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a // Can't happen
or a panic("bug: error in preparing new folder: " + err.Error())
or something here as I was wondering for a while if you'd gone insane to panic on a prepare error then realized it was in New() and should be fine :)
bump |
@st-review merge it |
@calmh: Merge failed:
|
@AudriusButkevicius ^ :/ |
…g and folder configuration changes Furthermore: 1. Cleans configs received, migrates them as we receive them. 2. Clears indexes of devices we no longer share the folder with
6e85505
to
d90b6a9
Compare
@st-review merge |
@AudriusButkevicius: Build status is |
@AudriusButkevicius: Build status is |
d90b6a9
to
03a9030
Compare
@st-review merge |
@AudriusButkevicius: Build status is |
@AudriusButkevicius: Build status is |
03a9030
to
d9fe167
Compare
@st-review merge |
@AudriusButkevicius: Build status is |
👌 Merged as af3b6f9. Thanks, @AudriusButkevicius! |
…g and folder configuration changes Furthermore: 1. Cleans configs received, migrates them as we receive them. 2. Clears indexes of devices we no longer share the folder with GitHub-Pull-Request: #3478
Purpose
lib/model, lib/config: Support "live" device removal, folder unsharing and folder configuration changes
Furthermore:
Testing
Manual tests, unit tests of questionable quality