lib/connections: Fix connection switching #3480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that it would be impossible to drop down to relay after establishing a direct connection Also, we should not drop the existing connection until after we've passed the validation steps, and it seems it's being dropped in two places unnecesserily at the moment.
|
Lgtm but let me do some actual testing since I anyway intended to do that |
|
I have a vague suspicion that something like the following can happen, but it's not confirmed at all:
But needs investigation... |
|
As we ourselves close, we need to make sure it never calls into the model again. |
|
@st-review merge it |
|
👌 Merged as a4f052a. Thanks, @AudriusButkevicius! |
st-review
pushed a commit
that referenced
this pull request
Aug 7, 2016
It seems that it would be impossible to drop down to relay after establishing a direct connection Also, we should not drop the existing connection until after we've passed the validation steps, and it seems it's being dropped in two places unnecesserily at the moment. GitHub-Pull-Request: #3480
|
No testing yet but it looks safe. We should look again into the possible race condition described above or something similar. |
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It seems that it would be impossible to drop down to relay after establishing a direct connection
Also, we should not drop the existing connection until after we've passed the validation steps,
and it seems it's being dropped in two places unnecesserily at the moment.
Testing
None what so ever.