Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore pkill error on resume #3630

Closed
wants to merge 1 commit into from
Closed

Conversation

peterhoeg
Copy link
Contributor

Purpose

The syncthing-resume.service will show as a failed service in case
there are no syncthing processes running after resume but it can be
safely ignored because it makes no difference.

Testing

  1. On a Linux distribution with systemd
  2. Make sure all syncthing processes are stopped
  3. Suspend
  4. Resume
  5. systemctl status syncthing-resume

You will see an error.

With this patch applied, the service is no longer in a failed state.

The ```syncthing-resume.service``` will show as a failed service in case
there are no syncthing processes running after resume but it can be
safely ignored because it makes no difference.
@AudriusButkevicius
Copy link
Member

@st-review merge

@st-review
Copy link

@AudriusButkevicius: Build status is pending. I'll wait until it goes green and then merge!

@st-review
Copy link

👌 Merged as 5019023. Thanks, @peterhoeg!

@st-review st-review closed this Sep 28, 2016
st-review pushed a commit that referenced this pull request Sep 28, 2016
The ```syncthing-resume.service``` will show as a failed service in case
there are no syncthing processes running after resume but it can be
safely ignored because it makes no difference.

GitHub-Pull-Request: #3630
@peterhoeg peterhoeg deleted the no_error branch September 28, 2016 10:50
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Nov 15, 2017
@syncthing syncthing locked and limited conversation to collaborators Nov 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants