Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/protocol: Serialize the all zeroes device ID to the empty string #3734

Closed
wants to merge 1 commit into from
Closed

lib/protocol: Serialize the all zeroes device ID to the empty string #3734

wants to merge 1 commit into from

Conversation

calmh
Copy link
Member

@calmh calmh commented Nov 14, 2016 •
edited

Purpose

Gets us introducedBy="" instead of introducedBy="AAAinfinitelymanyAs" in the config.

(omitempty does not apply here, as it is checked before serializing and a [32]byte is never "empty")

Testing

Dem unit tests

@AudriusButkevicius
Copy link
Member

@st-review merge

@st-review
Copy link

@AudriusButkevicius: Build status is failure -- refusing to merge.

@calmh
Copy link
Member Author

calmh commented Nov 14, 2016

@AudriusButkevicius this test is suspiciously randomly flaky...

--- FAIL: TestClusterConfig (0.00s)
    model_test.go:468: Incorrect device ID 4759525a5a51422d49524e5056345a2d543754433532572d4551594a3354542d46445157364d572d44464c4d5534322d5353535536454d2d46424b32564159 != 414952364c505a2d374b34505454562d555851534d55552d435051355957482d4f4544464949512d4a5547373737472d325951585852352d59443641575152
    model_test.go:471: Device1 should be flagged as Introducer
    model_test.go:474: Incorrect device ID 414952364c505a2d374b34505454562d555851534d55552d435051355957482d4f4544464949512d4a5547373737472d325951585852352d59443641575152 != 4759525a5a51422d49524e5056345a2d543754433532572d4551594a3354542d46445157364d572d44464c4d5534322d5353535536454d2d46424b32564159
    model_test.go:477: Device2 should not be flagged as Introducer

@calmh
Copy link
Member Author

calmh commented Nov 14, 2016

@st-jenkins retest this please

@calmh
Copy link
Member Author

calmh commented Nov 15, 2016

@st-review merge it

@st-review
Copy link

👌 Merged as 95c738e. Thanks, @calmh!

@st-review st-review closed this Nov 15, 2016
st-review pushed a commit that referenced this pull request Nov 15, 2016
@calmh
lib/protocol: Serialize the all zeroes device ID to the empty string
95c738e 
GitHub-Pull-Request: #3734
@calmh calmh deleted the emptyid branch November 15, 2016 06:42
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Nov 15, 2017
@syncthing syncthing locked and limited conversation to collaborators Nov 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calmh @AudriusButkevicius @st-review