lib/model: Minor cleanup to not fondle cfg.Raw things in handleDeintroductions #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@st-review merge |
|
@AudriusButkevicius: Build status is |
st-review
pushed a commit
that referenced
this pull request
Nov 17, 2016
…oductions GitHub-Pull-Request: #3739
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a bit cleaner in my opinion as it avoid pulling in a RawCopy and uses the existing methods to iterate over devices. Adds a new
RemoveDeviceon the config wrapper, similar toSetDevice, which abstracts away the copying and replacing stuff.Testing
Same as always...