lib/protocol: Apply input filtering on file names #3775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@st-review don't merge this until we've considered it carefully |
|
@calmh: Preventing merge for the time being. Push a new revision to reset! |
|
Metalint is |
|
Lgtm |
|
I'm fine with this. |
|
@st-review merge |
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Stricter filtering of incoming filenames. Essentially, names on the wire should be in canonical shortest possible form -- no internal
.or..components, no double slashes, not be one of.or.., not be absolute (start with/), not end with/, not start with../, and not be empty.(.stignore and similar special files should not be served, but it is not a protocol error to talk about them, it's a Syncthing specific limitation that we will not serve them. Coming in another PR.)
On Windows, files in index messages containing backslashes are filtered out with a warning. Requests for such files get an error return and a warning logged.
Testing
The filter methods have some unit tests on them.
Documentation
Requires additions to the spec to explain the restrictions we apply here.
@Unrud for review.