Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check file names for conflicts on Windows #3810

Closed
wants to merge 13 commits into from
Closed

Check file names for conflicts on Windows #3810

wants to merge 13 commits into from

Commits on Jan 19, 2017

  1. Check file names for conflicts on Windows

    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    d23b8e0 View commit details
    Browse the repository at this point in the history

  2. Verify file before opening

    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    6fa90f7 View commit details
    Browse the repository at this point in the history

  3. Close handle correctly

    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    11e87ba View commit details
    Browse the repository at this point in the history

  4. Use same documentation

    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    0ad273c View commit details
    Browse the repository at this point in the history

  5. Verify paths from external tools like inotify 

    Protect against scanning of short names on Windows. (maybe caused syncthing#3800)
Protect against the possibility of traversing Symlinks.
    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    d7dfe04 View commit details
    Browse the repository at this point in the history

  6. Revert "Verify paths from external tools like inotify" 

    This reverts commit bf3da33.
    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    8444b35 View commit details
    Browse the repository at this point in the history

  7. Check sub paths in scanner 

    Prevent scanner from following Symlinks and scanning the contents of colliding paths on Windows (e.g. scanning "foo" for the sub path "Foo")
    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    c56b361 View commit details
    Browse the repository at this point in the history

  8. Mark conflicting paths as deleted

    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    10f86af View commit details
    Browse the repository at this point in the history

  9. Add tests for osutil.CheckNameConflict

    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    e25fb9e View commit details
    Browse the repository at this point in the history

  10. Implement CheckNameConflict for Unix 

    Make CheckNameConflict system-independent and move system-dependent code into function FindRealFileName.
    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    6d0b7d5 View commit details
    Browse the repository at this point in the history

  11. Allow deletion updates for conflicting or Symlink-traversing files 

    TODO: Rebase with syncthing#3840
    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    d95b0ae View commit details
    Browse the repository at this point in the history

  12. Track version number for each folder in the db

    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    caa0dd6 View commit details
    Browse the repository at this point in the history

  13. Mark conflicting files as invalid (Update folder version to 2) 

    Prevent deletion of files with conflicting names in the cluster
    Unrud committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    98f44bd View commit details
    Browse the repository at this point in the history