lib/model: Consistently show folder description in startup messages #3825
Conversation
Since we anyway need the folderConfig for this I'm skipping the copying of all it's attributes that rwfolder did and just keeping the original around instead.
| @@ -20,6 +20,7 @@ func init() { | |||
|
|
|||
| type sendOnlyFolder struct { | |||
| folder | |||
| cfg config.FolderConfiguration | |||
| } | |||
There was a problem hiding this comment.
You could embed both, and drop the .cfg. everywhere.
There was a problem hiding this comment.
Yeah, that'd be cleaner. And fix the tests. I'll get to it.
| @@ -20,7 +20,7 @@ func init() { | |||
|
|
|||
| type sendOnlyFolder struct { | |||
| folder | |||
| cfg config.FolderConfiguration | |||
| config.FolderConfiguration | |||
| } | |||
There was a problem hiding this comment.
There was a joke about how Latvian president asked Lithuanian president to lend them tanks when Russian invaded Latvia.
The Lithuanian president asked whether the Latvian president would like one of them, or all of them... while Lithuania only had two...
TL;DR:
Given all of our two folders are embedding folder, I suggest we embed config in folder instead.
There was a problem hiding this comment.
I have a funny joke about where exactly you can embed your config...
anyway, that folder thing is a bit of a weird appending as it has almost no functionality. Should sort that out same day.
|
Fine. |
|
@st-review merge |
Since we anyway need the folderConfig for this I'm skipping the copying of all it's attributes that rwfolder did and just keeping the original around instead. GitHub-Pull-Request: #3825
st-review
added
the
frozen-due-to-age
We missed a couple of places to show the folder description (id + label) instead of just the ID.
Since we anyway need the folderConfig for this I'm skipping the copying of all it's attributes that rwfolder did and just keeping the original around instead.