gui: Package attribution and copyright bumps (fixes #3861) #3863

ProactiveServices · 2017-01-02T14:05:14Z

No description provided.

calmh

Thanks for digging through this and updating the list! I noted a couple of packages (geoip2, ginkgo, etc) that are not used by Syncthing itself but by other commands in here. Ideally those commands should show the info somewhere, but currently Syncthing is only one with an about box.

calmh · 2017-01-02T14:08:09Z

gui/default/syncthing/core/aboutModalView.html

@@ -20,15 +20,26 @@ <h1 class="text-center">
    <p translate>Syncthing includes the following software or portions thereof:</p>
    <ul class="list-unstyled two-columns">
      <li><a href="https://golang.org">The Go Programming Language</a>, Copyright &copy; 2012 The Go Authors.</li>
+      <li><a href="https://github.com/sasha-s/go-deadlock">sasha-s/go-deadlock</a>, Copyright &copy; 2016 sasha-s</li>
+      <li><a href="https://github.com/rcrowley/go-metrics">rcrowley/go-metrics</a>, Copyright &copy; 2012 Richard Crowley.</li>
+      <li><a href="https://github.com/oschwald/geoip2-golang">oschwald/geoip2-golang</a>, <a href="https://github.com/oschwald/maxminddb-golang">oschwald/maxminddb-golang</a>, Copyright &copy; 2015 <a href="mailto:oschwald@gmail.com">Gregory J. Oschwald</a>.</li>


Relay pool server only

calmh · 2017-01-02T14:08:18Z

gui/default/syncthing/core/aboutModalView.html

+      <li><a href="https://github.com/sasha-s/go-deadlock">sasha-s/go-deadlock</a>, Copyright &copy; 2016 sasha-s</li>
+      <li><a href="https://github.com/rcrowley/go-metrics">rcrowley/go-metrics</a>, Copyright &copy; 2012 Richard Crowley.</li>
+      <li><a href="https://github.com/oschwald/geoip2-golang">oschwald/geoip2-golang</a>, <a href="https://github.com/oschwald/maxminddb-golang">oschwald/maxminddb-golang</a>, Copyright &copy; 2015 <a href="mailto:oschwald@gmail.com">Gregory J. Oschwald</a>.</li>
+      <li><a href="https://github.com/onsi/ginkgo/">onsi/ginkgo/</a>, <a href="https://github.com/onsi/gomega/">onsi/gomega/</a> Copyright &copy; 2013-2014 Onsi Fakhouri.</li>


Tests for some other package only

calmh · 2017-01-02T14:08:28Z

gui/default/syncthing/core/aboutModalView.html

+      <li><a href="https://github.com/oschwald/geoip2-golang">oschwald/geoip2-golang</a>, <a href="https://github.com/oschwald/maxminddb-golang">oschwald/maxminddb-golang</a>, Copyright &copy; 2015 <a href="mailto:oschwald@gmail.com">Gregory J. Oschwald</a>.</li>
+      <li><a href="https://github.com/onsi/ginkgo/">onsi/ginkgo/</a>, <a href="https://github.com/onsi/gomega/">onsi/gomega/</a> Copyright &copy; 2013-2014 Onsi Fakhouri.</li>
+      <li><a href="https://github.com/minio/sha256-simd">minio/sha256-simd</a>, Copyright &copy; 2016 Minio, Inc.</li>
+      <li><a href="https://github.com/lib/pq">lib/pq</a>, Copyright &copy; 2011-2013 &apos;pq&apos; Contributors Portions Copyright &copy; 2011 Blake Mizerany.</li>


Relay pool server only

calmh · 2017-01-02T14:08:41Z

gui/default/syncthing/core/aboutModalView.html

+      <li><a href="https://github.com/jackpal/gateway">jackpal/gateway</a>, Copyright &copy; 2010 Jack Palevich.</li>
+      <li><a href="https://github.com/gogo/protobuf">gogo/protobuf</a>, Copyright &copy; 2013 The GoGo Authors.</li>
+      <li><a href="https://github.com/gobwas/glob">gobwas/glob</a>, Copyright &copy; 2016 Sergey Kamardin.</li>
+      <li><a href="https://github.com/cznic/lldb">cznic/lldb</a>, Copyright &copy; 2014 The lldb Authors.</li>


Discovery server only

ProactiveServices · 2017-01-02T14:23:52Z

How about a "-version" command line argument which would print version number and 3rd-party attributions? I think I could stretch my programming expertise that far ;-)
Or to keep the CLI output tidy, a brief notice referring the reader to the core app About box for the attributions, and then adding in sections into the modal.

calmh · 2017-01-02T14:33:03Z

I think typically it's only included in READMEs in the package, which we don't really do for those other commands but could. A -version or -copyright flag would be fine as well although I can't find another CLI program right now that includes that output so I think it may be overkill.

Not applicable / attributed elsewhere.

AudriusButkevicius · 2017-01-02T16:30:21Z

cmd/strelaypoolsrv/README.md

+
+[oschwald/geoip2-golang](https://github.com/oschwald/geoip2-golang), [oschwald/maxminddb-golang](https://github.com/oschwald/maxminddb-golang), Copyright (C) 2015 [Gregory J. Oschwald](mailto:oschwald@gmail.com).
+
+[lib/pq](https://github.com/lib/pq)</a>, Copyright (C) 2011-2013 'pq' Contributors Portions Copyright (C) 2011 Blake Mizerany.


I don't think this is used here. It's probably in discovery server. Also zinc(or something like that)/ql is used for discovery server too. Which is in memory query language.

Indeed, I was wrong about this before:

jb@unu:~/s/g/s/syncthing $ git grep cznic/ql | grep cmd cmd/stdiscosrv/ql.go: "github.com/cznic/ql" jb@unu:~/s/g/s/syncthing $ git grep lib/pq | grep cmd cmd/stdiscosrv/psql.go: _ "github.com/lib/pq" jb@unu:~/s/g/s/syncthing $

cmd/syncthing: Clarify -no-restart (avoids FAQs such as issue #3866), added STDEADLOCK envvars, minor grammatical tweaks. cmd/strelaysrv: Tidy up language and formatting in README, add section on specifying private relays in clients.

calmh · 2017-01-10T07:50:01Z

@st-review merge

st-review · 2017-01-10T07:50:16Z

👌 Merged as c953cdc. Thanks, @ProactiveServices!

GitHub-Pull-Request: #3863

ProactiveServices added 2 commits January 2, 2017 14:04

gui: Package attribution and copyright bumps (fixes #3861)

c9e794d

Merge remote-tracking branch 'refs/remotes/syncthing/master'

3c35308

calmh reviewed Jan 2, 2017

View reviewed changes

ProactiveServices added 3 commits January 2, 2017 16:10

strelaypoolsrv/README: Third-party attributions (issue #3861)

a2482ff

stdiscosrv/README: Third-party attribution (issue #3861)

9e504cf

gui: Removed superfluous attributions

94e4daa

Not applicable / attributed elsewhere.

ProactiveServices self-assigned this Jan 2, 2017

AudriusButkevicius reviewed Jan 2, 2017

View reviewed changes

cmd/syncthing, strelaysrv: Documentation / help text

3c00ac9

cmd/syncthing: Clarify -no-restart (avoids FAQs such as issue #3866), added STDEADLOCK envvars, minor grammatical tweaks. cmd/strelaysrv: Tidy up language and formatting in README, add section on specifying private relays in clients.

st-review closed this Jan 10, 2017

st-review pushed a commit that referenced this pull request Jan 10, 2017

gui: Package attribution and copyright bumps (fixes #3861)

c953cdc

GitHub-Pull-Request: #3863

st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jan 10, 2018

syncthing locked and limited conversation to collaborators Jan 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gui: Package attribution and copyright bumps (fixes #3861) #3863

gui: Package attribution and copyright bumps (fixes #3861) #3863

ProactiveServices commented Jan 2, 2017

calmh left a comment •

edited

calmh Jan 2, 2017

calmh Jan 2, 2017

calmh Jan 2, 2017

calmh Jan 2, 2017

ProactiveServices commented Jan 2, 2017 •

edited

calmh commented Jan 2, 2017

AudriusButkevicius Jan 2, 2017 •

edited

calmh Jan 3, 2017

calmh commented Jan 10, 2017

st-review commented Jan 10, 2017


		[oschwald/geoip2-golang](https://github.com/oschwald/geoip2-golang), [oschwald/maxminddb-golang](https://github.com/oschwald/maxminddb-golang), Copyright (C) 2015 [Gregory J. Oschwald](mailto:oschwald@gmail.com).

		[lib/pq](https://github.com/lib/pq)</a>, Copyright (C) 2011-2013 'pq' Contributors Portions Copyright (C) 2011 Blake Mizerany.

gui: Package attribution and copyright bumps (fixes #3861) #3863

gui: Package attribution and copyright bumps (fixes #3861) #3863

Conversation

ProactiveServices commented Jan 2, 2017

calmh left a comment • edited

Choose a reason for hiding this comment

calmh Jan 2, 2017

Choose a reason for hiding this comment

calmh Jan 2, 2017

Choose a reason for hiding this comment

calmh Jan 2, 2017

Choose a reason for hiding this comment

calmh Jan 2, 2017

Choose a reason for hiding this comment

ProactiveServices commented Jan 2, 2017 • edited

calmh commented Jan 2, 2017

AudriusButkevicius Jan 2, 2017 • edited

Choose a reason for hiding this comment

calmh Jan 3, 2017

Choose a reason for hiding this comment

calmh commented Jan 10, 2017

st-review commented Jan 10, 2017

calmh left a comment •

edited

ProactiveServices commented Jan 2, 2017 •

edited

AudriusButkevicius Jan 2, 2017 •

edited