Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/db: Don't panic on unknown folder in ListFolders (fixes #3584) #3869

Closed
wants to merge 1 commit into from
Closed

lib/db: Don't panic on unknown folder in ListFolders (fixes #3584) #3869

wants to merge 1 commit into from

Conversation

calmh
Copy link
Member

@calmh calmh commented Jan 4, 2017

Purpose

All the panics seem to come from ListFolders at startup. Lets just not panic there and see what falls out.

@AudriusButkevicius
Copy link
Member

@st-review merge

@st-review
Copy link

👌 Merged as 920274b. Thanks, @calmh!

@st-review st-review closed this Jan 4, 2017
st-review pushed a commit that referenced this pull request Jan 4, 2017
@calmh @AudriusButkevicius
lib/db: Don't panic on unknown folder in ListFolders (fixes #3584)
920274b 
GitHub-Pull-Request: #3869
@ghost
Copy link

ghost commented Jan 4, 2017 •
edited by ghost

Any concerns about cherry picking this patch against 0.14.15 for testing? (It's easier than the git sources for me)

@calmh
Copy link
Member Author

calmh commented Jan 4, 2017

Should apply cleanly; otherwise, use latest dev build which includes it: https://build.syncthing.net/job/syncthing/lastSuccessfulBuild/artifact/

@ghost
Copy link

ghost commented Jan 4, 2017 

 * Applying patches from /etc/portage/patches/net-p2p/syncthing-0.14.15 ...
 *   920274bce47a6ea21625ccad656c83e67d315af3.patch ...               [ ok ]
 * User patches applied.

It finishes checking folders, however this is new:

panic: bug: lookup of nonexistent device ID

@ghost ghost mentioned this pull request Jan 4, 2017
Closed
@calmh calmh deleted the fix-3584 branch January 30, 2017 22:19
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jan 5, 2018
@syncthing syncthing locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calmh @AudriusButkevicius @st-review