gui, lib/config: Add notification about new release channels #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -200,7 +200,7 @@ func TestOverriddenValues(t *testing.T) { | |||
| AlwaysLocalNets: []string{}, | |||
| OverwriteRemoteDevNames: true, | |||
| TempIndexMinBlocks: 100, | |||
| UnackedNotificationIDs: []string{}, | |||
| UnackedNotificationIDs: []string{"channelNotification"}, // added in 17->18 migration | |||
There was a problem hiding this comment.
Suggest you break this over multiple lines so that we end up with:
[]string{
"foo", //bar
"baz". //nuf
}
|
@st-review lgtm |
|
@AudriusButkevicius: Noted! Need another LGTM or explicit merge command. |
imsodin
reviewed
Jan 30, 2017
| @@ -0,0 +1,15 @@ | |||
| <configuration version="17"> | |||
There was a problem hiding this comment.
Its 17 to 18 migration
There was a problem hiding this comment.
Ok. I was simply comparing to v17.xml where the numbers matched, no "deeper insights" :)
There was a problem hiding this comment.
No you're right it should be 18. Fixed. Also another thing, the override test was flaky.
|
@st-review merge it |
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As above
Testing
Clicketyclick
Screenshots
The link goes to https://build.syncthing.net/docs/223/users/releases.html