cmd/syncthing, lib/config: Pause/resume all devices whithout argument #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the state of this PR? |
|
@st-review lgtm |
|
@AudriusButkevicius: Noted! Need another LGTM or explicit merge command. |
calmh
reviewed
Mar 4, 2017
|
|
||
| cfg, ok := s.cfg.Devices()[device] | ||
| if !ok { | ||
| http.Error(w, "not found", http.StatusNotFound) |
cmd/syncthing/gui.go
Outdated
| } else { | ||
| device, err := protocol.DeviceIDFromString(deviceStr) | ||
| if err != nil { | ||
|
|
|
@st-jenkins retest this please |
|
@st-review lgtm |
st-review
pushed a commit
that referenced
this pull request
Mar 4, 2017
GitHub-Pull-Request: #3989 LGTM: AudriusButkevicius, calmh
imsodin
added a commit
to imsodin/docs
that referenced
this pull request
Mar 4, 2017
st-review
pushed a commit
to syncthing/docs
that referenced
this pull request
Mar 31, 2017
GitHub-Pull-Request: #305
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This allows to pause/resume all devices at once via API, essentially pausing/resuming syncthing. Use case: https://forum.syncthing.net/t/syncthing-server-client-and-backup-strategy-with-rsnapshot/9256
Testing
Just manual testing.
Documentation
Definitely needs an update - will do, but not tonight.