Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: moving deadcode #4008

Closed
wants to merge 2 commits into from
Closed

build: moving deadcode #4008

wants to merge 2 commits into from

Conversation

andresvia
Copy link
Contributor

Purpose

There is small piece of dead code in build.go as a consequence building on go < 1.5 panics, instead of log.Fatalf with friendly message.

Testing

eval $(gimme 1.4)
go get ./...
go run build.go

@calmh
Copy link
Member

calmh commented Feb 26, 2017 via email

@andresvia
Copy link
Contributor Author

Indeed, removing the go vendor availability check as this is already covered by the min version check.

@calmh
Copy link
Member

calmh commented Feb 26, 2017

@st-review merge it

build: Remove obsolete check for vendoring support

Skip-check: authors

@st-review
Copy link

👌 Merged as 566c348. Thanks, @andresvia!

@st-review st-review closed this Feb 26, 2017
st-review pushed a commit that referenced this pull request Feb 26, 2017
Skip-check: authors

GitHub-Pull-Request: #4008
@st-review st-review added the pr-merged Legacy label used in the past for pull requests merged to the main tree label Jan 15, 2018
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jul 15, 2018
@syncthing syncthing locked and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion pr-merged Legacy label used in the past for pull requests merged to the main tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants