lib/events, cmd/syncthing: Correct GlobalID in debug and make since arameter optional #4025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameter optional
|
@st-review merge it lib/events, cmd/syncthing: Correct GlobalID in debug and mark "since" parameter optional Skip-check: metalint |
st-review
pushed a commit
that referenced
this pull request
Mar 7, 2017
… parameter optional Skip-check: metalint GitHub-Pull-Request: #4025
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are minor fixes as a side product of writing documentation.
The since parameter is not actually required for /rest/events and this is already used in the gui code.
The debug log is simply offset by one compared to /rest/events due to first logging then incrementing GlobalID,