gui: Restrict GUI listening ports to >1024, add help (fixes #4020) #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a pattern validator to the GUI listen port field that checks for port numbers 1024 and above. Also adds a help link pointing to the (new) page talking about GUI listen port numbers. That page has information on how to work around the restriction, in general terms. Also changes the header from "GUI Listen Addresses" to the singular version, because we only support one listen address today.
|
Seems it accepts 01025, does go accept that? |
|
Yup: https://play.golang.org/p/7Ewrf2QaZw
There is however one bug, 127.0.0.1:00080 is accepted by the regexp. Let me fix that.
|
|
Fixed, now passes the tests I can think of, manually.
|
|
@st-review merge |
st-review
pushed a commit
that referenced
this pull request
Apr 24, 2017
This adds a pattern validator to the GUI listen port field that checks for port numbers 1024 and above. Also adds a help link pointing to the (new) page talking about GUI listen port numbers. That page has information on how to work around the restriction, in general terms. Also changes the header from "GUI Listen Addresses" to the singular version, because we only support one listen address today. GitHub-Pull-Request: #4116
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pattern validator to the GUI listen port field that checks for port numbers 1024 and above. Also adds a help link pointing to the (new) page talking about GUI listen port numbers. That page has information on how to work around the restriction, in general terms. The related pull request is here: syncthing/docs#315
Also changes the header from "GUI Listen Addresses" to the singular version, because we only support one listen address today.