build: Build Debian packages for non-syncthing targets (fixes #4193) #4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things like the package name "syncthing" was hardcoded, which is not awesome. With this in place we can build debs called syncthing-discosrv, syncthing-relaysrv and syncthing-relaypoolsrv. I don't actually intend to build and publish the relaypoolsrv, but the others can be good. Using the "syncthing-" prefix to make the obvious "apt-cache search syncthing" actually show them etc.
|
@st-review lgtm |
|
@AudriusButkevicius: Noted! Need another LGTM or explicit merge command. |
|
Or rather. i don't care too much about this. |
|
@st-review lgtm as well obviously |
st-review
pushed a commit
that referenced
this pull request
Jun 9, 2017
Things like the package name "syncthing" was hardcoded, which is not awesome. With this in place we can build debs called syncthing-discosrv, syncthing-relaysrv and syncthing-relaypoolsrv. I don't actually intend to build and publish the relaypoolsrv, but the others can be good. Using the "syncthing-" prefix to make the obvious "apt-cache search syncthing" actually show them etc. GitHub-Pull-Request: #4206 LGTM: AudriusButkevicius, calmh
viable-hartman
pushed a commit
to viable-hartman/syncthing
that referenced
this pull request
Aug 25, 2017
…ng#4193) Things like the package name "syncthing" was hardcoded, which is not awesome. With this in place we can build debs called syncthing-discosrv, syncthing-relaysrv and syncthing-relaypoolsrv. I don't actually intend to build and publish the relaypoolsrv, but the others can be good. Using the "syncthing-" prefix to make the obvious "apt-cache search syncthing" actually show them etc. GitHub-Pull-Request: syncthing#4206 LGTM: AudriusButkevicius, calmh
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things like the package name "syncthing" was hardcoded, which is not
awesome. With this in place we can build debs called syncthing-discosrv,
syncthing-relaysrv and syncthing-relaypoolsrv. I don't actually intend
to build and publish the relaypoolsrv, but the others can be good. Using
the "syncthing-" prefix to make the obvious "apt-cache search syncthing"
actually show them etc.