Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/upgrade: 0.x to 1.0 is a minor upgrade #4226

Closed
wants to merge 1 commit into from
Closed

lib/upgrade: 0.x to 1.0 is a minor upgrade #4226

wants to merge 1 commit into from

Conversation

calmh
Copy link
Member

@calmh calmh commented Jun 25, 2017

This removes the special handling of minor versions as major when the
actual major is zero, and adds the special case that upgrades from 0.x
to 1.x are considered minor. 0.x to 2.x or 1.x to 2.x etc are still
considered major.

This removes the special handling of minor versions as major when the
actual major is zero, and adds the special case that upgrades from 0.x
to 1.x are considered minor. 0.x to 2.x or 1.x to 2.x etc are still
considered major.
@AudriusButkevicius
Copy link
Member

@st-review merge

@st-review
Copy link

👌 Merged as db1dc99. Thanks, @calmh!

@st-review st-review closed this Jun 25, 2017
st-review pushed a commit that referenced this pull request Jun 25, 2017
This removes the special handling of minor versions as major when the
actual major is zero, and adds the special case that upgrades from 0.x
to 1.x are considered minor. 0.x to 2.x or 1.x to 2.x etc are still
considered major.

GitHub-Pull-Request: #4226
@calmh calmh deleted the newmajor branch June 27, 2017 12:36
viable-hartman pushed a commit to viable-hartman/syncthing that referenced this pull request Aug 25, 2017
This removes the special handling of minor versions as major when the
actual major is zero, and adds the special case that upgrades from 0.x
to 1.x are considered minor. 0.x to 2.x or 1.x to 2.x etc are still
considered major.

GitHub-Pull-Request: syncthing#4226
@st-review st-review added the pr-merged Legacy label used in the past for pull requests merged to the main tree label Jan 15, 2018
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jul 15, 2018
@syncthing syncthing locked and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion pr-merged Legacy label used in the past for pull requests merged to the main tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants