Build: Add maximum compression #4229
Conversation
|
Hi! Thanks. In principle I'm fine with this, apart from excluding etc and extra from Windows. The extra stuff includes documentation. The etc stuff may currently be useless, but it's not guaranteed to be so in the future and it's equally useless for some other platforms we build for. |
|
Also clean up the comments on the |
rasa
force-pushed
the
build-max-compression
branch
from
7a9e718
to
9079196
Compare
|
@calmh Thanks for reviewing, and considering this PR. I removed the exclusion of the /etc folder, and fixed the 'all' comment. Let me know if there's anything else needed. Thanks! |
build.go
Outdated
| @@ -63,8 +65,8 @@ type archiveFile struct { | |||
|
|
|||
| var targets = map[string]target{ | |||
| "all": { | |||
| // Only valid for the "build" and "install" commands as it lacks all | |||
| // the archive creation stuff. | |||
| // Only valid for the "build", "install", "tar" and "zip" commands | |||
There was a problem hiding this comment.
Actually, why not add the required stuff to this target, maybe keep the later magic to add all binaries automatically, instead of reusing the syncthing target? The filenames etc will make more sense that way.
There was a problem hiding this comment.
Yeah, that makes more sense. Fixing now...
There was a problem hiding this comment.
Sorry, I started to hack on it, and I'm not sure the best way forward, sorry.
|
Maybe scale it back to just the compression changes and add the other stuff at a later time when appropriate. |
rasa
force-pushed
the
build-max-compression
branch
from
9079196
to
a675254
Compare
|
OK, I backed out the build all changes. Let me know if this fits the bill. |
rasa
changed the title
|
@st-jenkins retest this please |
|
@st-review merge it build: Use maximum compression when archiving |
|
@rasa Thanks! |
GitHub-Pull-Request: syncthing#4229
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Purpose
Add maximum compression to .tar and .zip files.
Removed per @calmh:
Remove /etc files from zip file, as they are unneeded on Windows.Fix tar builds on Windows, as some Windows users might prefer tars over zips (I do).Add 'all' option to tar and zip targets, so all executables can be shipped, if desired.Testing
Results of
go run build.go zipbefore and after (1.1% improvement):Authorship
Ross Smith II (rasa) ross@smithii.com