lib/versioner: base versions path to working dir (#4188) #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@st-jenkins retest this please |
|
@liusy182 Thanks, looks good. |
|
@st-jenkins retest this please |
|
@st-review merge it please lib/versioner: Interpret versions path relative to folder path (fixes #4188) |
|
@calmh: Build status is |
st-review
pushed a commit
that referenced
this pull request
Jul 3, 2017
viable-hartman
pushed a commit
to viable-hartman/syncthing
that referenced
this pull request
Aug 25, 2017
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
base versions path to working dir (#4188)
Testing
base settings: In folder, advanced settings, "File Versioning" dropdown, choose "Stagger file versioning" option.
- Scenario 1:
Leave field "Versions Path" empty and save.
Expect staggered files to be synced to
<<Folder Path>>/.stversionsfolder where<<Folder Path>>is the "Folder Path" value displayed in the same dialog.- Scenario 2:
Give a absolute path in "Versions Path" field, E.g. "
/tmp/testpath" and save.Expect staggered files to be synced to the given path. E.g. "
/tmp/testpath"- Scenario 3:
Give a relative path in "Versions Path" field, E.g. "
testpath" and save.Expect staggered files to be synced to the path relative to "Folder Path", E.g.
<<Folder Path>>/testpath