Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add folder list to table cell title #4266

Closed
wants to merge 2 commits into from
Closed

Add folder list to table cell title #4266

wants to merge 2 commits into from

Conversation

maximal
Copy link
Contributor

@maximal maximal commented Jul 24, 2017

This is useful when you wanna view all folder names but their list is truncated by overflow: hidden; text-overflow: ellipsis;.

This is useful when you wanna view all folder names but their list is truncated by `overflow: hidden; text-overflow: ellipsis;`
@maximal
Copy link
Contributor Author

maximal commented Jul 24, 2017

Actually, it could be a tooltip here. I can post it in this pull request.

@AudriusButkevicius
Copy link
Member

Whatever is done here should be done for folders in relation to devices.

@maximal
Copy link
Contributor Author

maximal commented Jul 24, 2017

It is device related. That is in this list:
image

@AudriusButkevicius
Copy link
Member

Yes, but equivalent information is shown for folders (listing the devices its shared with).

@maximal
Copy link
Contributor Author

maximal commented Jul 24, 2017

Sorry, I’m not sure I understand you correctly.

Do you mean this selected area?

image

@AudriusButkevicius
Copy link
Member

Yes.

@maximal
Copy link
Contributor Author

maximal commented Jul 24, 2017

Done.

@AudriusButkevicius
Copy link
Member

Can you provide a screenshot how it looks in a long list?

@maximal
Copy link
Contributor Author

maximal commented Jul 24, 2017

Like that:

image

@AudriusButkevicius
Copy link
Member

@st-review lgtm

@st-review
Copy link

@AudriusButkevicius: Noted! Need another LGTM or explicit merge command.

@calmh
Copy link
Member

calmh commented Jul 27, 2017

@st-review merge it

gui: Add title attributes for shared devices/folders

Skip-check: authors

@st-review
Copy link

👌 Merged as 54155cb. Thanks, @maximal!

@st-review st-review closed this Jul 27, 2017
st-review pushed a commit that referenced this pull request Jul 27, 2017
Skip-check: authors

GitHub-Pull-Request: #4266
LGTM: AudriusButkevicius
viable-hartman pushed a commit to viable-hartman/syncthing that referenced this pull request Aug 25, 2017
Skip-check: authors

GitHub-Pull-Request: syncthing#4266
LGTM: AudriusButkevicius
@st-review st-review added the pr-merged Legacy label used in the past for pull requests merged to the main tree label Jan 15, 2018
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jul 28, 2018
@syncthing syncthing locked and limited conversation to collaborators Jul 28, 2018
@maximal maximal deleted the patch-1 branch June 3, 2021 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion pr-merged Legacy label used in the past for pull requests merged to the main tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants