lib/upnp: Disable confusing messages #4312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@st-review merge |
|
👌 Merged as 606fce0. Thanks, @AudriusButkevicius! |
|
@calmh this merged a failed build it seems? |
|
Uh, yeah, wtf. |
|
@AudriusButkevicius There was a race condition of sorts, as statuses are not visible in the github API until they have been reported (even if they have been tagged as "required") and tc doesn't report status until it starts the build. I've taught the mergebot to understand and wait for "required" statuses now so this should work as expected. |
viable-hartman
pushed a commit
to viable-hartman/syncthing
that referenced
this pull request
Aug 25, 2017
GitHub-Pull-Request: syncthing#4312
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Write on Windows to some virtual adapters always times out.
And the invalid ID makes people think something is wrong.