lib/model,lib/ignores: Fix fs regressions (fixes #4313, fixes #4314) #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of folder ignores are convenient for shared ignores. For all systems with (functioning) symlinks an out of folder includes can easily be replaced by a symlink to that path. However for windows users it might not be replaceable that easily. I don't think it does harm keeping this backward compatibility. |
|
@st-review merge lib/model, lib/ignores: Properly handle out of folder ignores and free space checks (fixes #4313, fixes #4314) |
|
👌 Merged as 0a96a11. Thanks, @AudriusButkevicius! |
viable-hartman
pushed a commit
to viable-hartman/syncthing
that referenced
this pull request
Aug 25, 2017
…e space checks (fixes syncthing#4313, fixes syncthing#4314) GitHub-Pull-Request: syncthing#4318
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably deprecate escaping filesystems for ignores.