cmd/syncthing: Add some common security releated HTTP headers (fixes #4360) #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@st-review merge |
st-review
pushed a commit
that referenced
this pull request
Sep 10, 2017
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These:
Number 4 we already do of course, but I sprinkled some utf-8 where appropriate.
Numbers 2-3 are uncontroversial and shouldn't do any harm.
Number 1 might be an issue. Potentially for apps that wrap Syncthing (@Nutomic, @kozec, @canton7), also I recall from forums that there are people who have their own web pages that load the Syncthing UI in a part of them. I added a new GUI config option
InsecureAllowFrameLoadingto turn off this header.