lib/model: Hide temporary files on Windows while they are in use (fixes #4382) #4394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd argue to leave the temp files hidden in case of error? |
|
Possibly, but then we also need to audit all the paths where we might have a fast path directly to rename and so on, which I don't want to do at the moment. :) |
|
@st-review merge |
|
@AudriusButkevicius: Build status is |
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Hide the temp files while we are using them.
Testing
None whatsoever. I'm just assuming that the Hide() call works and that it's valid to call Hide() on an open file. If someone on Windows could confirm that it would be lovely.
I don't think there are any ways out of a temp file other than via sharedPullerState.finalClose - if there are this would result in files becoming permanently hidden which would be bad.