Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/beacon: Don't exit after a single write failure (fixes #4414) #4415

Closed
wants to merge 1 commit into from
Closed

lib/beacon: Don't exit after a single write failure (fixes #4414) #4415

wants to merge 1 commit into from

Conversation

calmh
Copy link
Member

@calmh calmh commented Oct 12, 2017

Purpose

Actually send IPv4 broadcasts.

Testing

❓

@calmh
lib/beacon: Don't exit after a single write failure (fixes syncthing#…
d6bd010 
…4414)

With VPNs and stuff we can get a single failure on an interface that
supposedly supports broadcasts without it being fatal.
@calmh calmh changed the title lib/beacon: Don't exit after a single write failure lib/beacon: Don't exit after a single write failure (fixes #4414) Oct 12, 2017
@AudriusButkevicius
Copy link
Member

@st-review merge

@st-review
Copy link

👌 Merged as 2f08f80. Thanks, @calmh!

@st-review st-review closed this Oct 12, 2017
st-review pushed a commit that referenced this pull request Oct 12, 2017
@calmh @AudriusButkevicius
lib/beacon: Don't exit after a single write failure (fixes #4414)
2f08f80 
With VPNs and stuff we can get a single failure on an interface that
supposedly supports broadcasts without it being fatal.

GitHub-Pull-Request: #4415
@calmh calmh deleted the fix-4414 branch October 12, 2017 07:44
@st-review st-review added the pr-merged Legacy label used in the past for pull requests merged to the main tree label Jan 15, 2018
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Oct 13, 2018
@syncthing syncthing locked and limited conversation to collaborators Oct 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion pr-merged Legacy label used in the past for pull requests merged to the main tree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calmh @AudriusButkevicius @st-review