build: handle split gopath #4447
Conversation
build.go
Outdated
| break | ||
| } | ||
| } | ||
| if !inside { | ||
| fmt.Println("You are running this outside of GOPATH/src/github.com/syncthing/syncthing, this might cause failure!") |
There was a problem hiding this comment.
While you're at it, maybe tweak this to something softer and more grammatical? (Yes, me bikeshedding messages again)
You seem to have GOPATH set but the Syncthing source not placed correctly within it. Proceed with caution. or something?
There was a problem hiding this comment.
Sure thing. Please go ahead and bikeshed my language as much as you can. I am decent at correcting somebody else's messages but rubbish at producing good ones myself.
Plus I use "this" and "that" so much that it even confuses myself when I read it later.
|
I don't have things set up to trivially pull in pull requests to my local source to I'm taking this on faith |
|
@st-review merge build: Handle split GOPATH |
|
@calmh: Build status is |
|
oh and please do correct capitalization of the commit subjects and we won't have to tweak them 💃 |
| } | ||
| } | ||
| if !inside { | ||
| fmt.Println("You seem to have GOPATH set but the Syncthing source not placed correctly within it, which may cause problems.") |
There was a problem hiding this comment.
I didn't like your "proceed with caution" part that well, as the user can't really do anything anymore at that point, cautiously or not (except for hitting ctrl-c in a hurry). I hope I didn't just make it worse.
I was wondering why you always included my commit message in the st-review command - I don't seem to be at my most attentive at the moment. :D |
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Follow up to #4425 to handle multiple gopaths.