Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/watchaggregator: Relax test timing requirement for the benefit of macos #4469

Closed
wants to merge 1 commit into from

Conversation

imsodin
Copy link
Member

@imsodin imsodin commented Oct 26, 2017

Apparently nothing is save.

@imsodin
Copy link
Member Author

imsodin commented Oct 26, 2017

@st-review merge

@st-review
Copy link

@imsodin: Build status is pending. I'll wait until it goes green and then merge!

@st-review
Copy link

@imsodin: Build status is failure -- refusing to merge.

@imsodin
Copy link
Member Author

imsodin commented Oct 26, 2017

The irony: A different flaky test failure on a PR fixing a flaky test...

@imsodin
Copy link
Member Author

imsodin commented Oct 26, 2017

@st-review merge

@st-review
Copy link

👌 Merged as b999b58. Thanks, @imsodin!

@st-review st-review closed this Oct 26, 2017
st-review pushed a commit that referenced this pull request Oct 26, 2017
@imsodin imsodin deleted the watchTiming branch October 26, 2017 21:09
@st-review st-review added the pr-merged Legacy label used in the past for pull requests merged to the main tree label Jan 15, 2018
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Oct 27, 2018
@syncthing syncthing locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion pr-merged Legacy label used in the past for pull requests merged to the main tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants