-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/model: Incremental block stats usage reporting #4498
Conversation
ad7e6a6
to
b879e78
Compare
What is the plan to account for the difference if the folder was restarted since the last report or not? |
Probably the stats need to live somewhere outside of the folder, and the sharedPullerState should just increment some global. |
Since we only care about the ratio between the numbers I don't think it's a big deal. This is probably sane anyway, we'll get less but fresher data and if we want more aggregation we can do it over several days server side. |
@st-review lgtm |
@calmh: Noted! Need another LGTM or explicit merge command. |
Sure, for the important metrics this makes sense. I was bringing this up because Audrius already added this nice new "Totals to date" statistics, which is obviously not very important, but flashy, and this particular metric will be hampered by this. So I guess lgtm from my side unless @AudriusButkevicius rather wants to implement his "outside of folder" proposal? |
Moved the stats to the global variable. |
429ba77
to
35ac940
Compare
35ac940
to
d98398b
Compare
@st-review merge |
@AudriusButkevicius: Build status is |
👌 Merged as 386cb27. Thanks, @AudriusButkevicius! |
GitHub-Pull-Request: #4498 LGTM: calmh
...