Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/model: Incremental block stats usage reporting #4498

Closed

Conversation

AudriusButkevicius
Copy link
Member

...

@imsodin
Copy link
Member

imsodin commented Nov 8, 2017

What is the plan to account for the difference if the folder was restarted since the last report or not?
I don't know exactly what you do when analyzing the data, but you could record the folder start time/block stat reset time to get information about the duration in which this data was accumulated.

@AudriusButkevicius
Copy link
Member Author

Probably the stats need to live somewhere outside of the folder, and the sharedPullerState should just increment some global.

@calmh
Copy link
Member

calmh commented Nov 8, 2017

Since we only care about the ratio between the numbers I don't think it's a big deal. This is probably sane anyway, we'll get less but fresher data and if we want more aggregation we can do it over several days server side.

@calmh
Copy link
Member

calmh commented Nov 8, 2017

@st-review lgtm

@st-review
Copy link

@calmh: Noted! Need another LGTM or explicit merge command.

@imsodin
Copy link
Member

imsodin commented Nov 8, 2017

Sure, for the important metrics this makes sense. I was bringing this up because Audrius already added this nice new "Totals to date" statistics, which is obviously not very important, but flashy, and this particular metric will be hampered by this. So I guess lgtm from my side unless @AudriusButkevicius rather wants to implement his "outside of folder" proposal?

@AudriusButkevicius
Copy link
Member Author

Moved the stats to the global variable.

@AudriusButkevicius
Copy link
Member Author

@st-review merge

@st-review
Copy link

@AudriusButkevicius: Build status is pending. I'll wait until it goes green and then merge!

@st-review
Copy link

👌 Merged as 386cb27. Thanks, @AudriusButkevicius!

@st-review st-review closed this Nov 9, 2017
st-review pushed a commit that referenced this pull request Nov 9, 2017
@st-review st-review added the pr-merged Legacy label used in the past for pull requests merged to the main tree label Jan 15, 2018
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Nov 10, 2018
@syncthing syncthing locked and limited conversation to collaborators Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion pr-merged Legacy label used in the past for pull requests merged to the main tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants