lib/watchaggregator: Don't care about timings during testing on darwin #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsodin
changed the title
imsodin
force-pushed
the
dropMacTimings
branch
from
5bc1607
to
3a484af
Compare
|
@st-review merge |
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now stops checking the timings of notifications on darwin, but still does it on other platforms. I guess that's an ok compromise - internal timings will hardly vary between platforms.
While at it I renamed s/new/newAggregator/, that was a leftover of un-exporting
New. And I sped up timings a bit (not waiting anymore for timeouts once everything we need was received).