lib/model: Don't update ignore hash when pull fails #4522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't we have set the correct bits on all the ignored files as part of the pulling, even if some other files fail to pull for whatever reason? |
|
Yes, that case is fine, the problem is the other way round: If a file got un-ignored and fails to be pulled, it won't get queried again. |
|
Ah |
|
@st-review merge |
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing the PR about pull scheduling on reconnect I realized that the ignores hash is incorrectly updated even if a pull fails. This means on a subsequent pull, ignored files aren't included anymore, which is relevant due to #4460, and should thus also be in v0.14.41.