lib/connections Fix Did not complete all the connection attempt #4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2017 22:36
Did not complete all the connection attempt, the first attempt if the priority fails, premature return
Did not complete all the connection attempt,
xjtdy888
changed the title
xjtdy888
changed the title
|
@st-review merge it lib/connections: Actually make connection attempts for lower priority addresses as well Skip-check: authors |
st-review
pushed a commit
that referenced
this pull request
Nov 21, 2017
… addresses as well Skip-check: authors GitHub-Pull-Request: #4535
|
@xjtdy888 Thanks |
calmh
pushed a commit
that referenced
this pull request
Nov 22, 2017
… addresses as well Skip-check: authors GitHub-Pull-Request: #4535
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Nov 22, 2017
|
I posted a comment here previous saying this PR was broken. It's not, I was aiming for another PR. Leaving this comment here in case the previous one went out by email, sorry. |
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed Did not complete all the connection attempt,
the first attempt if the priority fails, premature return