lib/events: Fix unmarshaling of EventType #4540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When is it actually unmarshalled? |
|
Not in syncthing directly, but when you want to unmarshal a JSON object from the REST API into an |
|
@st-review merge lib/events: Fix unmarshaling of EventType skip-check: authors |
|
👌 Merged as b2af8f1. Thanks, @monstermunchkin! |
st-review
pushed a commit
that referenced
this pull request
Nov 22, 2017
skip-check: authors GitHub-Pull-Request: #4540
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This allows to properly unmarshal an
Event. Prior to this change, unmarshaling would have failed with:Testing
A Test has been added which tries unmarshaling an
Event.