lib/osutil, lib/scanner: Run symlink test on Windows when possible #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmh
changed the title
imsodin
reviewed
Nov 25, 2017
| // '/' does not work in link's content | ||
| oldname = filepath.FromSlash(oldname) | ||
|
|
||
| // need the exact location of the oldname when its relative to determine if its a directory |
There was a problem hiding this comment.
If you're really worried about the dictionary attacks: Its->it's
This should have gone to review, such that I don't wast time with multiple such non-issues.
There was a problem hiding this comment.
:D none of this code is written by us.
There was a problem hiding this comment.
Oh damn, I don't read the copyright stuff. But that's a relieve, because that functions is s**t xD
|
@st-review merge |
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a shit-ugly function to create symlinks on Windows in tests only. The walk test now runs on Windows instead of being skipped (not visible in the code; but the build server now has one more passed test and one fewer skipped). Other tests could do the same.