Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/fs: Prolong test timeout on darwin, hopefully fixing flakyness #4576

Closed
wants to merge 1 commit into from

Conversation

imsodin
Copy link
Member

@imsodin imsodin commented Dec 6, 2017

Teamcity reports long durations when the flaky test passes on darwin, so extending the timeout seems to have a good chance of minimizing flakyness - lets see (and hope).

@imsodin
Copy link
Member Author

imsodin commented Dec 6, 2017

@st-review merge

@st-review
Copy link

@imsodin: Build status is pending. I'll wait until it goes green and then merge!

@AudriusButkevicius
Copy link
Member

I wonder if the tests could be refactored not to rely on timeouts?

@st-review
Copy link

👌 Merged as c005b8d. Thanks, @imsodin!

st-review pushed a commit that referenced this pull request Dec 6, 2017
@st-review st-review closed this Dec 6, 2017
@calmh
Copy link
Member

calmh commented Dec 6, 2017

I suspect the issue is not Darwin as such either, but that the Darwin "build server" is an old laptop in my garage that also occasionally does other stuff. Whereas the windows and linux builders are mostly dedicated vm:s.

@imsodin
Copy link
Member Author

imsodin commented Dec 6, 2017

Mentioning "darwin" is just shorter than "slow darwin build server" - that's all there is to it.

And these test don't "rely" on timeout, they just give up after a certain amount of time, such that the "global" timeout isn't triggered and other tests can run as well. It would have probably been better to extend the timeout time regardless of OS, as it doesn't matter any when the test doesn't fail.

@st-review st-review added the pr-merged Legacy label used in the past for pull requests merged to the main tree label Jan 15, 2018
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Dec 7, 2018
@syncthing syncthing locked and limited conversation to collaborators Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion pr-merged Legacy label used in the past for pull requests merged to the main tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants