lib/config, lib/discover: Support new discovery cluster (ref #4618) #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g#4618) This adds one new feature, that discovery servers can have ?nolookup to be used only for announces. The default set of discovery servers is changed to: - discovery.s.n used for lookups. This is dual stack load balanced over all discovery servers, and returns both IPv4 and IPV6 results when they exist. - discovery-v4.s.n used for announces. This has IPv4 addresses only and the discovery servers will update the unspecified address with the IPv4 source address, as usual. - discovery-v6.s.n which is exactly the same for IPv6.
|
@st-review mergw |
|
I'm sorry, @AudriusButkevicius. I'm afraid I don't know what you mean. I know how to |
|
@st-review merge |
st-review
pushed a commit
that referenced
this pull request
Jan 5, 2018
This adds one new feature, that discovery servers can have ?nolookup to be used only for announces. The default set of discovery servers is changed to: - discovery.s.n used for lookups. This is dual stack load balanced over all discovery servers, and returns both IPv4 and IPV6 results when they exist. - discovery-v4.s.n used for announces. This has IPv4 addresses only and the discovery servers will update the unspecified address with the IPv4 source address, as usual. - discovery-v6.s.n which is exactly the same for IPv6. GitHub-Pull-Request: #4647
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This adds one new feature, that discovery servers can have ?nolookup to
be used only for announces. The default set of discovery servers is
changed to:
discovery.s.n used for lookups. This is dual stack load balanced over
all discovery servers, and returns both IPv4 and IPV6 results when they
exist.
discovery-v4.s.n used for announces. This has IPv4 addresses only and
the discovery servers will update the unspecified address with the IPv4
source address, as usual.
discovery-v6.s.n which is exactly the same for IPv6.
Testing
Works for me in manual testing...
Compatibility
There is no protocol changes for the new stuff. We will retain the DNS records for
discovery-v4-4anddiscovery-v6-4(same certificate as the new cluster) so clients using the old method will still work (forever), just using wastefully twice as many lookups as necessary and getting red flags fordiscovery-v[46]-[23]once those are removed in the future.