lib/fs: Unflake watch tests (fixes #4687) #4715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a number of timing related things, leaving just the total test timeout now bumped to one minute. Normally we get the filesystem events within a second or so, so this doesn't affect the test time in the successfull case. If we don't actually get the events we expect within a minute I think we are legitimately in "failed" territory.
|
I've rerun it on the Windows & Linux builders a couple of times and it doesn't seem more broken than before at least. |
|
@st-review lgtm |
|
@imsodin: Noted! Need another LGTM or explicit merge command. |
|
@st-review lgtm |
st-review
added
the
pr-merged
st-review
pushed a commit
that referenced
this pull request
Jan 28, 2018
This removes a number of timing related things, leaving just the total test timeout now bumped to one minute. Normally we get the filesystem events within a second or so, so this doesn't affect the test time in the successfull case. If we don't actually get the events we expect within a minute I think we are legitimately in "failed" territory. GitHub-Pull-Request: #4715 LGTM: imsodin, AudriusButkevicius
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This removes a number of timing related things, leaving just the total test timeout now bumped to one minute. Normally we get the filesystem events within a second or so, so this doesn't affect the test time in the successfull case. If we don't actually get the events we expect within a minute I think we are legitimately in "failed" territory.
Testing
I've run this in a loop on the Mac builder (which often fails with the code in
master) and it's been fine for a few minutes. Leaving it up to the build server to see if this passes on linux etc...