lib/protocol: Test for IsEquivalent #4996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsodin
approved these changes
Jun 8, 2018
There was a problem hiding this comment.
Nice, thanks!
To state the obvious (I assume it's what triggered this PR): The part about invalid infos of the test will need to be adapted to check for whichever semantics are chosen as discussed in #4952 (comment).
|
Yep. |
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Jun 8, 2018
* master: lib/protocol: Test for IsEquivalent (syncthing#4996) gui: Add tabs in device editor (syncthing#4986) lib/config, lib/model: Handle shared with information in config (fixes syncthing#4870) (syncthing#4974) gui: Restrict shown decimals and restrict size of header columns (syncthing#4973) cmd/stfindignored: Default to current directory cmd/stfindignored: Make that 2018 cmd/stfindignored: Add utility gui: Hide allowed networks if unused (syncthing#4989) lib/protocol: Correct block size calculation on 32 bit archs (fixes syncthing#4990) (syncthing#4991) lib/upgrade: Tests should pass on darwin-386 gui, man: Update docs & translations gui: Don't remove the slash from path '/' (fixes syncthing#4983) (syncthing#4988) lib/fs: Resolve 8.3 filenames from watcher (ref syncthing#3800) (syncthing#4975) lib/scanner: Skip block size hysteresis test in -short mode lib/db: Add index to track locally needed files (syncthing#4958)
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Specify the current behavior of the function, as there was no test already that I could find.
Testing
Indeed.