Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/ignore Have a nice treeview for handling ignores - Next Gen Ignores #5132

Closed
wants to merge 3 commits into from

Commits on Aug 17, 2018

  1. gui/ignore: add skeleton tree view to pick files to sync (fixes synct…

    …hing#2491)
    
    This commit changes the editFolderModalView/folder-ignores tab by
    adding two nested tabs under it. The Advanced tab holds the currently
    existing text rules. The new Basic tab holds a tree view.
    
    The tree view shows the existing files and folders that exist under
    the given root folder configured in syncthing. This tree view is
    populated from the root folder's global state found at the /db/browse
    endpoint.
    ibizaman committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    a931d59 View commit details
    Browse the repository at this point in the history
  2. gui/ignore: sync folder ignores tree view with text rules (fixes sync…

    …thing#2491)
    
    This commit syncs the treeview and text rules used to ignore
    files.
    
    The logic here is to share a common object call
    $scope.syncedFiles. The tree view and text rules get synced when we
    switch from tab to tab.
    
    When we go from the Advanced (text rules) tab to the Basic (tree view)
    tab, we parse the text rules, produce the syncedFiles object and
    populate the checkboxes in the tree as needed. A special case is when
    the text rules are not parseable (because too complicated), then we
    deactivate the tree view. This step is complicated.
    
    When we go from the Basic to the Advanced tab, we produce the shared
    syncedFiles object and use that to rewrite the text rules. This step
    is simple.
    ibizaman committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    162b9e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2018

  1. lib/ignore: only use spaces

    ibizaman committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    0a6ecdd View commit details
    Browse the repository at this point in the history