lib/model: Fail test instead of panic due to closing channel twice #5508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudriusButkevicius
approved these changes
Feb 5, 2019
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Feb 12, 2019
* master: Fix builds on Windows without CGO (syncthing#5518) lib/db, lib/model: Remove dead code (syncthing#5517) gui: Add missing translation string (fixes syncthing#5515) lib/model: Don't use LocalDeviceID as normal id in tests (syncthing#5512) gui, man, authors: Update docs, translations, and contributors lib/model: Improve TestIssue5063 (syncthing#5509) lib/model: Add progressEmitter to supervisor (model) (syncthing#5510) lib/model: Fail test instead of panic due to closing channel twice (syncthing#5508) lib/model: Helperize test os and remove error return value (syncthing#5507) gui: Enable large blocks by default, add to config dialog (syncthing#5405)
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both more readable test results and less mess lying around as cleanup functions can execute.
This is one of a few unit test related PRs resulting from https://forum.syncthing.net/t/openbsd-test-debugging/12799